#26
|
||||
|
||||
I'm still working out a couple of bugs. I found a case where it doesn't get the positions right... I will hopefully get some work done on it today. I can add a link and tag line without a problem. I also have it adding the buyin and level for tourneys.
Once I get the last of the bugs out I can finalize the documentation and clean up the code. I'll be breaking it out into pieces so it's easier to maintain. Once that is done I'll begin working on the Full Tilt conversions. |
#27
|
||||
|
||||
TP posted the new version which I believe now has all the kinks worked out. Formatting is now a fairly simple matter to manage (suggestions still welcome of course). Please try it out with your PS hands and let me know if there are any problems.
I've started to put together the converter for fulltilt - more on that end next week. |
#28
|
||||
|
||||
More suggstions - I'm going for a cleaner, less cluttered look, as you will see:
(Quoting from ) That should be enough suggestions to hold you for a bit. BTW - once we are supporting Full Tilt HHs, I'll actually be using this (and making more suggestions, of course). Thanks again for all the work on this. |
#29
|
||||
|
||||
I like all those suggestions you made TP, I will second them.
|
#30
|
||||
|
||||
how's this
Better?
Ring game, $0.50/$1 No Limit, 9 players Hand History Converted by MP2: $173.25 MP3: $136.95 MP4: $51.80 CO: $100 Button: $97.70 SB: $99 HERO (BB): $76.30 UTG: $92.50 MP1: $105.95 SB posts Small Blind $0.5 HERO posts Big Blind $1 Dealt to: HERO (BB) Q A Dealt to: UTG J A Pre-flop ($1.5) UTG calls $1 ($2.5) MP1 folds MP2 folds MP3 folds MP4 folds CO calls $1 ($3.5) Button calls $1 ($4.5) SB calls $0.5 ($5) HERO checks Flop: 8 7 A ($5) SB: checks HERO: bets $4 ($9) UTG: calls $4 ($13) CO: folds Button: folds SB: folds Turn: 8 7 A 7 ($13) HERO: bets $12 ($25) UTG: calls $12 ($37) River: 8 7 A 7 9 ($37) HERO: checks UTG: checks HERO wins $35.15 with two pair, Aces and Sevens |
#31
|
||||
|
||||
Overall the look of this converter is nice. Good job Decoder and TP.
1 suggestion if I may: Would be nice if we had the option of saving the hand history and it's comments. One of the reasons why I like pokerhand.org. I sometimes don't care to go online, but want to review a few HH or their comments. For this reason, a few months ago, I created a folder which I added to my desktop, named TPFHH. I copy/saved a few informative HH which I basically use to review and study on my own time. Too tedious to try to look through the many HH threads in the HSIHPT or Hand Discussion threads, to find the one which caught my attention or explained something important. Just a thought, but if it cannot be intergrated within the converter, maybe it could be set as a Save Hand History option on either UserCP or better yet; a FAV icon placed next to the rep icon for easier access. My |
#32
|
||||
|
||||
Looks MUCH better to me.
Here's one more pass for you: Also, did you code in logic for chopped pots, etc? It's getting pretty close now. |
#33
|
|||
|
|||
much easier on the eyes. I likey....
|
#34
|
||||
|
||||
Here's the latest output.
I've corrected the player order at the top - SB first. Fixed the preflop line and added hero's cards there. The other known cards (mucked or shown) are displayed at the end. I think split pots are working properly now. I'm not worried about specifying why one hand may win over another - the only reason would be a lower kicker. At PS they only indicate a lower kicker during showdown, not sure how the other sites handle that... Ring game, $0.50/$1 No Limit, 9 players Hand History Converted by SB: $99 HERO (BB): $76.30 MP2: $173.25 MP3: $136.95 MP4: $51.80 CO: $100 Button: $97.70 UTG: $92.50 MP1: $105.95 SB posts Small Blind $0.5 HERO posts Big Blind $1 Pre-flop: Q A ($1.5) UTG calls $1 ($2.5) MP1 folds MP2 folds MP3 folds MP4 folds CO calls $1 ($3.5) Button calls $1 ($4.5) SB calls $0.5 ($5) HERO checks Flop: 8 7 A ($5) SB: checks HERO: bets $4 ($9) UTG: calls $4 ($13) CO: folds Button: folds SB: folds Turn: 8 7 A 7 ($13) HERO: bets $12 ($25) UTG: calls $12 ($37) River: 8 7 A 7 9 ($37) HERO: checks UTG: checks UTG shows J A HERO wins $35.15 with two pair, Aces and Sevens |
#35
|
|||
|
|||
I think this is perfect.
|
#36
|
||||
|
||||
here's another example, a split pot - and a really fucked up hand too...
Tournament game, buy-in $4.00+0.40, Level IX $300/$600 No Limit, 7 players Hand History Converted by MP2: $11227 CO: $9095 HERO (Button): $10506 SB: $7710 BB: $3054 UTG: $32820 MP1: $29814 Players post $50 ante SB posts Small Blind $300 BB posts Big Blind $600 Pre-flop: J J ($1250) UTG raises to $2400 ($3650) MP1 folds MP2 folds CO folds HERO raises to $10456 ($14106) SB folds BB calls $2404 ($16510) UTG calls $8056 ($24566) Flop: 8 3 2 ($24566) Turn: 8 3 2 T ($24566) River: 8 3 2 T J ($24566) BB shows A A UTG shows 9 9 HERO wins $10672 with a flush, Jack high BB wins $3221 with a flush, Jack high UTG wins $10673 with a flush, Jack high |
#37
|
||||
|
||||
This is looking REALLY good now.
The only suggestion I have is to lose the ":" after all the actions postflop, to match preflop. ie: Flop: 8 7 A ($5) SB checks HERO bets $4 ($9) UTG calls $4 ($13) CO folds Button folds SB folds Turn: 8 7 A 7 ($13) HERO bets $12 ($25) UTG calls $12 ($37) River: 8 7 A 7 9 ($37) HERO checks UTG checks That is one very nice looking HH right there. Thank you so much. The newest version is up. Looking forward to running some Full Tilt hands through soon. |
#38
|
||||
|
||||
Oh, and I'm probably going to reformat the index file to fit into the rest of the TP site, like this page, for example (assuming I can get it to fit and look pretty):
But that's just silly front end stuff. |
#39
|
|||
|
|||
I like the latest converter a lot.
|
#40
|
||||
|
||||
Yeah, me too. I think it's just about perfect now, honestly (see very minor tweaks suggested above). It's clean and simple and IMO the esiest to read HH I've ever seen.
And that makes me happy. Once we're Full Tilt capable (since that's where 98% of my play is these days), I'll be using this for all of my posted HHs. I hope you guys will too. If we all get used to a standard output format, regardless of the input format (maybe we can bribe (+Rep) de-coder to add support for UB and other sites too!), it will be much, much, much easier to quickly read and respond to posted HHs. |
#41
|
||||
|
||||
done. That was an easy one...
Once I'm sure that we don't require changes to the generated xml I can really get to work on full tilt. I'm pretty sure we're there, I don't think any more information is required and I've got the split pot working. The only thing I might lose at this point is if someone posts a dead blind... I haven't found a hand with that case so I haven't been able to test it - at worst that would affect the pot amount by a SB+BB... |
#42
|
||||
|
||||
Have you tested antes with the most recent changes? If so, I think we're good to go.
|
#43
|
||||
|
||||
OK, one more suggestion I just thought of after reading : How about adding the name of the site to the HH. ie:
Ring game, $2/$4 No Limit, 5 players becomes Poker Stars cash game, $2/$4 No Limit, 5 players ("Cash" sounds cooler than "ring" too, IMO) Also, in the first hand above, I'm not seeing villain's hole cards at the showdown. |
#44
|
||||
|
||||
Yes - it worked on my test hands.
|
#45
|
||||
|
||||
Ok, I've made those changes as well (sending shortly). As for villain's hole cards - they were cut off along the way - if you look at the original it's there.
|
#46
|
||||
|
||||
I just ran my first Full Tilt HH test. Results .
|
#47
|
||||
|
||||
Yeah, the FT HHs definitely need some work. I'm going to be posting a handful of them here tonight, so feel free to test away with them.
|
#48
|
||||
|
||||
I found the problem. My hands work fine - your don't because you have amounts with commas in them. Just play with less money and it'll work fine
|
#49
|
||||
|
||||
I've uploaded the new version. We should test out some high stakes hands too. Here, let's give this a go...
Before: Full Tilt Poker Game #1896599427: Table Alvarez - $500/$1000 - $30,000 Cap No Limit Hold'em - 5:31:45 ET - 2007/03/01 Seat 1: ballsrider ($66,498.50) Seat 5: durrrr ($54,755) Seat 8: 93TilInfinity ($73,494.50) 93TilInfinity posts the small blind of $500 ballsrider posts the big blind of $1,000 The button is in seat #5 *** HOLE CARDS *** durrrr calls $1,000 93TilInfinity raises to $5,000 ballsrider folds durrrr raises to $30,000, and is capped 93TilInfinity calls $25,000, and is capped durrrr shows [Ah 9h] 93TilInfinity shows [Kc Ks] *** FLOP *** [2c 6c 3h] *** TURN *** [2c 6c 3h] [5h] *** RIVER *** [2c 6c 3h 5h] [As] durrrr shows a pair of Aces 93TilInfinity shows a pair of Kings durrrr wins the pot ($60,999) with a pair of Aces *** SUMMARY *** Total pot $61,000 | Rake $1 Board: [2c 6c 3h 5h As] Seat 1: ballsrider (big blind) folded before the Flop Seat 5: durrrr (button) showed [Ah 9h] and won ($60,999) with a pair of Aces Seat 8: 93TilInfinity (small blind) showed [Kc Ks] and lost with a pair of Kings After: Full Tilt Cash game, $/$ Limit, 3 players <-- Stakes still missing. Hand History Converted by SB: $73494.50 <-- Line spacing not showing up after cut and paste...? That's odd. BB: $66498.50 Button: $54755 SB posts Small Blind $500 BB posts Big Blind $1000 Pre-flop: ($1500) Button calls $1000 ($2500) SB raises to $1000 ($3000) <---Hrm. These numbers aren't correct. See above. BB folds Button raises to $1000 ($3000) <-- Same here, obv. SB calls $25000 ($28000) Flop: 2 6 3 ($28000) Turn: 2 6 3 5 ($28000) River: 2 6 3 5 A ($28000) Button wins $60999 with a pair of Aces <-- Showdown isn't correct. We should see both players hole cards and results (see bolded lines above). Last edited by Talking Poker; 03-04-07 at 01:10 PM. |
#50
|
||||
|
||||
Would need some commentary on a friend's hand history. He thinks the play was incorrect, I think the play was fine. Would your converter be able to handle this?
*I like the idea that players names are kept out of the hand history. |
|
|